Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Scala 2.13.13 and 2.12.19 #1059

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

SethTisue
Copy link
Contributor

@SethTisue SethTisue commented Feb 26, 2024

review: @rochala ?

@SethTisue SethTisue force-pushed the scala-2-juggernaut-rolls-on branch from d634e44 to 5a0091b Compare February 26, 2024 23:08
@SethTisue SethTisue marked this pull request as draft February 26, 2024 23:09
@SethTisue
Copy link
Contributor Author

SethTisue commented Feb 26, 2024

I first tried this without the Metals version bump, but it failed because mtags wasn't published for 2.13.13 for that Metals version. But on Metals 1.2.2, there are Scalameta-related compilation failures and I don't have time to dig into it anytime in the next few weeks (and it's unfamiliar stuff for me anyway). Can someone else take this over? @rochala, @tgodzik ?

@rochala
Copy link
Collaborator

rochala commented Feb 27, 2024

I'll do this on Scastie part

@tgodzik
Copy link
Contributor

tgodzik commented Feb 27, 2024

I think a rerun should also work, I backpublished for 1.2.0

@SethTisue SethTisue force-pushed the scala-2-juggernaut-rolls-on branch from 5a0091b to a0208ea Compare March 8, 2024 15:53
@SethTisue SethTisue marked this pull request as ready for review March 8, 2024 15:57
@SethTisue
Copy link
Contributor Author

I removed the Metals upgrade and this now passes CI except for the metalsRunner / cachedCiTest failure which I also see happening in other open PRs, so probably this is now mergeable?

@tgodzik tgodzik requested a review from rochala March 8, 2024 16:33
@rochala rochala merged commit 6d1ba86 into scalacenter:main Mar 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants