Log debuggee command #2192
Open
Log debuggee command #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Nov 16, 2023
| @@ -200,6 +200,11 @@ object Forker { | |||
| val envMap = builder.environment() | |||
| envMap.putAll(env.asJava) | |||
| builder.redirectErrorStream(false) | |||
| logger.info("Forking process:") | |||
There was a problem hiding this comment.
Would we want it under debug rather?
There was a problem hiding this comment.
How can we get debug logs with Bloop?
There was a problem hiding this comment.
we would need to add a flag to starting params. Maybe it's fine to do info.
tgodzik
approved these changes
Nov 16, 2023
adpi2
force-pushed
the
log-debuggee-command
branch
3 times, most recently
from
045d8ec to
001e5e4
Compare
adpi2
force-pushed
the
log-debuggee-command
branch
from
001e5e4 to
cb9997b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Jprefix to close Remove stripPrefix("-J") workaround for Metals #1456