Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mulit-Reader FIFO #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mulit-Reader FIFO #11

wants to merge 3 commits into from

Conversation

wogh533
Copy link

@wogh533 wogh533 commented Sep 27, 2023

Multi-Reader FIFO 추가 하였습니다.

dale40
dale40 reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dale40 dale40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인 파일이 두개가 있습니다. 중복된 거라면 하나를 제거해주세요.

@wogh533
Copy link
Author

wogh533 commented Sep 27, 2023

중복 파일 삭제했습니다.

dale40
dale40 requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dale40 dale40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the empty generation parameterized

@dale40
Copy link
Contributor

dale40 commented Jul 26, 2024

@wogh533 현재 empty 신호들이 [0], [1]으로 2개의 reader만 지원하는데,
이부분을 generate 문 같은 거 써서 parameter로 들어오는 임의의 reader 갯수도 지원하도록 변경해줘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dale40 dale40 dale40 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wogh533 @dale40