Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dubious retry in vulpix #21801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revert dubious retry in vulpix #21801

wants to merge 2 commits into from

Conversation

som-snytt
Copy link
Contributor

Revert #17373 which introduced a retry in the test rig, but of dubious utility.

At some point, I stopped seeing those timeouts. I never found a root cause; I don't see timeouts using 3.3.0 and JDK 17. This is under WSL2/Ubuntu.

Also use @nowarn for Unsafe API.

@som-snytt som-snytt added the area:vulpix Issues tied with Vulpix, the internal compiler testing framework. label Oct 17, 2024
@som-snytt som-snytt added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Nov 22, 2024
@som-snytt
Copy link
Contributor Author

Taking fasttrack label to mean no-brainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:vulpix Issues tied with Vulpix, the internal compiler testing framework. fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@som-snytt