-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate infix named args #21565
base: main
Are you sure you want to change the base?
Deprecate infix named args #21565
Conversation
2cfa491
to
4d25ea3
Compare
Probably better as an external lint. |
With named tuples this becomes more urgent. I agree, we should deprecate that syntax. |
Looking at #21681, seems like this is common enough to require a compiler warning. Would you like to revive this PR? (Otherwise I am happy to do it.) |
The warning at parser goes unseen in October because the arg is now a unituple. (I don't even know the lingo yet.) So the warning info is only meaningful as an addendum to the error here. The warning should be backported to LTS. I'll try that after a second coffee. |
67ba634
to
1d8838c
Compare
There is not much to addend, as it turns out. Mention the named arg, in case they didn't count the parens; handle the very contrived example where the param name and the tuple element name coincide. |
1d8838c
to
4448c8b
Compare
Should be a migration warning (not deprecation); should not warn on named tuple ops. Probably move the warning to typer (as I meant to do) (or I was thinking refchecks, but it needs to see infix ops). |
Addresses #19072
Ports scala/scala#10857