Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate infix named args #21565

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

Addresses #19072
Ports scala/scala#10857

@som-snytt som-snytt force-pushed the discussion/19072-infix-named-arg branch from 2cfa491 to 4d25ea3 Compare September 7, 2024 17:04
@som-snytt
Copy link
Contributor Author

Probably better as an external lint.

@odersky
Copy link
Contributor

odersky commented Oct 1, 2024

With named tuples this becomes more urgent. I agree, we should deprecate that syntax.

@mbovel
Copy link
Member

mbovel commented Oct 22, 2024

Probably better as an external lint.

Looking at #21681, seems like this is common enough to require a compiler warning. Would you like to revive this PR? (Otherwise I am happy to do it.)

@som-snytt som-snytt reopened this Oct 22, 2024
@som-snytt
Copy link
Contributor Author

som-snytt commented Oct 22, 2024

The warning at parser goes unseen in October because the arg is now a unituple. (I don't even know the lingo yet.) So the warning info is only meaningful as an addendum to the error here. The warning should be backported to LTS. I'll try that after a second coffee.

@som-snytt som-snytt force-pushed the discussion/19072-infix-named-arg branch 2 times, most recently from 67ba634 to 1d8838c Compare October 22, 2024 21:01
@som-snytt
Copy link
Contributor Author

There is not much to addend, as it turns out. Mention the named arg, in case they didn't count the parens; handle the very contrived example where the param name and the tuple element name coincide.

@som-snytt som-snytt force-pushed the discussion/19072-infix-named-arg branch from 1d8838c to 4448c8b Compare October 22, 2024 22:25
@som-snytt
Copy link
Contributor Author

Should be a migration warning (not deprecation); should not warn on named tuple ops. Probably move the warning to typer (as I meant to do) (or I was thinking refchecks, but it needs to see infix ops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants