Try to fix stale symbol errors connected to lazyvals #21424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual stale symbol error, while recent, seems correct to me. There is no reason why an earlier phase (Mixins) should see denotation from a later phase (LazyVals) - if the opposite is true (like with the fix here) the bringForward method is able to recover with a NoDenotation, which is what we want.
|
does not seem to work at all, unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual stale symbol error, while recent, seems correct to me. There is no reason why an earlier phase (Mixins) should see a denotation from a later phase (LazyVals) - if the opposite is true (like with the fix here) the bringForward method is able to recover with a NoDenotation, which I think is what we want.
Based on #21280