-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Publish build scans to develocity.scala-lang.org #21386
Conversation
@adpi2 Overall, this looks good to me. One thing I noticed is that we should add the Develocity banner in the README (I'll share an example soon). By the way, have you intentionally left out (for later) configuring the test retry functionality (for flaky test detection)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
c74f7c2
to
7b262f7
Compare
7b262f7
to
44bdfed
Compare
The
The TASTy tree is expected to be printed in the temporary file I believe there is some sort of interaction between |
At the moment, the Develocity Build Cache does not work properly with our compilation tests, because the cache key does not take into account the sources that are read in the tests. Keeping the build cache would lead to false cache hits, so it is better to disable it for the time being.
This is ready for review. The scans should appear automatically on develocity.scala-lang.org after we merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is not yet ready to merge because we want to disable local and remote cache. We will re-enable it later once we agree on the rollout plan. |
For the Context, Gradle is supporting the Scala Center with a free instance of Develocity that we can use to analyze the build scans of our open-source projects.
This PR configures publishing of build scans for every GitHub workflow of the
scala/scala3
CI. All build scans will be publicly available on https://develocity.scala-lang.org/.The
sbt-develocity
plugin can also do test retry and flaky test detection, which I will activate in a subsequent PR, on some test classes.