Make @experimental final #20260
Closed
Make @experimental final #20260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noti0na1
added
area:library
There was a problem hiding this comment.
We should rebase #20222 on this branch to ensure this change fixes the issue.
Otherwise LGTM
noti0na1
force-pushed
the
make-experimental-final
branch
from
8d41005 to
1d7f304
Compare
|
@noti0na1 Could you squash and rebase? |
|
The current failure is fixed in #20264 |
noti0na1
force-pushed
the
make-experimental-final
branch
from
1d7f304 to
fc43000
Compare
|
@nicolasstucki #20222 has been rebased on to this PR and passes all the tests. |
|
Closed, the change will be put together with #20222. |
|
I extend /** Used to cross-compile with Scala 2. */
class experimental extends scala.annotation.experimental/** Used to cross-compile with Scala 3. */
class experimental extends scala.annotation.StaticAnnotation |
|
Use a type alias instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #20223, this PR makes @experimental final.
Should unblock #20222.