Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move warn tests from tests/neg to tests/warn: Batch 2 #19243

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Move warn tests from tests/neg to tests/warn: Batch 2 #19243

merged 2 commits into from
Jan 19, 2024

Conversation

szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Dec 11, 2023 •
edited
Loading

The second batch of tests moved from tests/neg to tests/warn.
PR 3/5 (merge consecutively, per Nicolas' suggestion

Split up version of #18829

@szymon-rd szymon-rd force-pushed the move-error-warn-b2 branch 2 times, most recently from d7fdaf3 to 9f3ef59 Compare December 17, 2023 14:58
@szymon-rd szymon-rd force-pushed the move-error-warn-b1 branch 2 times, most recently from ec7f963 to 3754628 Compare January 11, 2024 10:42
Base automatically changed from move-error-warn-b1 to main January 11, 2024 12:12
nicolasstucki
nicolasstucki reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

tests/warn/opaque-match.scala Outdated



case _: List[T] => ??? // warn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not remove these \n in the last line

tests/warn/1828.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/1828.scala

tests/warn/type-lambda.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/type-lambda.scala

tests/warn/t2755.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/t2755.scala

tests/warn/3324b.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/3324b.scala

tests/warn/conditionalWarnings.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/conditionalWarnings.scala

tests/warn/gadt.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/gadt.scala

tests/warn/html.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/html.scala

tests/warn/or-type-trees.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/or-type-trees.scala

tests/warn/refined-types.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should delete tests/neg-deep-subtype/refined-types.scala

@nicolasstucki nicolasstucki merged commit cacf2b6 into main Jan 19, 2024
37 checks passed
@nicolasstucki nicolasstucki deleted the move-error-warn-b2 branch January 19, 2024 15:36
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jun 27, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
@WojciechMazur
Backport "Move warn tests from tests/neg to tests/warn: Batch 2" to L…
244ecdf 
…TS (#20844)

Backports #19243 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@szymon-rd @nicolasstucki @Kordyjan