Add two tests for local root encapsulation #18836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linyxus
force-pushed
the
check-no-local-roots
branch
from
46c33a8 to
eedc5d5
Compare
Linyxus
changed the title
Linyxus
force-pushed
the
check-no-local-roots
branch
from
eedc5d5 to
72ae1c1
Compare
odersky
approved these changes
Nov 16, 2023
odersky
requested changes
Nov 16, 2023
|
@Linyxus What should we do with this PR? |
|
Local roots should not leak in the signature but reach capabilities could. So this two tests are not applicable any more. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #18699 (comment).