Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future migration warning for alphanumeric infix operator #18835

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Nov 3, 2023
@nicolasstucki nicolasstucki force-pushed the migration–warning–for–alphanumeric–infix-operator branch 2 times, most recently from a235205 to bd2dc3e Compare November 3, 2023 14:32
@nicolasstucki nicolasstucki marked this pull request as ready for review November 6, 2023 08:17
@nicolasstucki nicolasstucki force-pushed the migration–warning–for–alphanumeric–infix-operator branch from bd2dc3e to c79b8e8 Compare November 9, 2023 10:40
@dwijnand
Copy link
Member

Do you see this warning on GitHub too?

image

Any idea why it pops up here?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Nov 13, 2023

I copy pasted the name form somewhere else when I created the branch. Unfortunately, it was formatted with unicode dashes and I only noticed it after I opened the PR.

I haven't had any issues checking it out so far.

@sjrd
Copy link
Member

sjrd commented Nov 13, 2023

Let's make sure they don't make it into the merge commit message. The branch name will disappear but not the commit message.

@nicolasstucki
Copy link
Contributor Author

I will create a new PR from a new branch to make sure everything is clean.

@nicolasstucki
Copy link
Contributor Author

Replaced with #18908

@dwijnand dwijnand deleted the migration–warning–for–alphanumeric–infix-operator branch November 13, 2023 10:47
nicolasstucki added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants