Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages for missing commas and more #18785

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Better error messages for missing commas and more #18785

merged 3 commits into from
Oct 30, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 29, 2023 •
edited
Loading

Three measures:

  1. Classify an id as infix operator only if following can start an operand
  2. Detect and report spread operators in illegal positions
  3. Mention , in addition to ) or ] in error messages when a , could have been missing

Fixes #18734

@odersky
Classify an id as infix operator only if following can start an operand
ffb2ab7 
Also, detect and report spread operators in illegal positions
@odersky
Mention , in addition to ) in error messages
45fc82a
@odersky
Override operator detection logic in interactive mode
fca7d06 
In interactive mode the token after an operator might not yet exist, so we
should disregard that info when deciding whether we see an infix operator or
not.
@odersky odersky requested a review from rochala October 29, 2023 18:08
@odersky
Copy link
Contributor Author

odersky commented Oct 29, 2023

@rochala Can you give this a review? There are some interactions with pc.

@odersky odersky merged commit 10a2b83 into scala:main Oct 30, 2023
18 checks passed
@odersky odersky deleted the fix-18734 branch October 30, 2023 12:54
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 22, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "Better error messages for missing commas and more" to LTS (#…
a7608fe 
…20746)

Backports #18785 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochala rochala rochala approved these changes

Assignees

@rochala rochala

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Improve error when missing a comma in Apply args
3 participants
@odersky @rochala @Kordyjan