Add missing -Yexplicit-nulls for presentation compiler #18776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
force-pushed
the
add-explicit-null-to-presentation-compiler
branch
from
4da9ce8 to
7136850
Compare
tgodzik
requested changes
Nov 6, 2023
presentation-compiler/src/main/dotty/tools/pc/AutoImports.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/ConvertToNamedArgumentsProvider.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/HoverProvider.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/HoverProvider.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/PcInlineValueProviderImpl.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/PcInlineValueProviderImpl.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/completions/CompletionProvider.scala
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala
Outdated
Show resolved
Hide resolved
presentation-compiler/src/main/dotty/tools/pc/completions/InterpolatorCompletions.scala
Outdated
Show resolved
Hide resolved
|
Well, this is a tradeoff of having crashes from working on untyped trees as on typed ones, which are significantly harder to debug than simple null pointer assertion failure. They will also fail fast instead of some deeper place in the code. The cost of this is the |
rochala
force-pushed
the
add-explicit-null-to-presentation-compiler
branch
from
1ce3c5a to
1016d16
Compare
tgodzik
added
the
area:presentation-compiler
WojciechMazur
pushed a commit
that referenced
this pull request
Jun 23, 2024
With a new definition of untyped trees, it is now required to have `-Yexplicit-nulls` flag in modules that use them in order to have proper type checking. This PR adds the missing flag. Without the flag, it was possible to first assign untyped trees to typed trees, and secondly use extension methods for typed trees which can be seen at `KeywordsCompletions.scala` with usage of `untpdTree.filterSubtrees`. It is also blocked by: #18775 I can also make a workaround in the unmanaged module, but it will require a dependency on nightly version / a new release from metals. [Cherry-picked e149e4c]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a new definition of untyped trees, it is now required to have
-Yexplicit-nullsflag in modules that use them in order to have proper type checking. This PR adds the missing flag.Without the flag, it was possible to first assign untyped trees to typed trees, and secondly use extension methods for typed trees which can be seen at
KeywordsCompletions.scalawith usage ofuntpdTree.filterSubtrees.It is also blocked by: #18775
I can also make a workaround in the unmanaged module, but it will require a dependency on nightly version / a new release from metals.