Properly format enclosing class of private access error message #18688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the error message showed `module class XYZ$`. Now it shows `object XYZ`. This does not fix the issue scala#18686, it only improves a bit the current error message.
nicolasstucki
commented
Oct 13, 2023
| @@ -4,6 +4,6 @@ | |||
| | value getDFType is not a member of DFBits[(8 : Int)]. | |||
| | Extension methods were tried, but the search failed with: | |||
| | | |||
| | method getDFType cannot be accessed as a member of DFType.type from module class i12573$package$. | |||
| | method getDFType cannot be accessed as a member of DFType.type from package object i12573$package. | |||
There was a problem hiding this comment.
There are further improvements on this error message pending in #18406.
sjrd
approved these changes
Oct 13, 2023
|
Actually, this fix is already in #18406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the error message showed
module class XYZ$. Now it showsobject XYZ.This does not fix the issue #18686, it only improves a bit the current error message.