Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach provablyDisjoint to fold compile-time constants #18015

Closed
wants to merge 1 commit into from

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand linked an issue Jun 20, 2023 that may be closed by this pull request
@dwijnand dwijnand marked this pull request as ready for review June 21, 2023 09:52
@dwijnand dwijnand requested a review from mbovel June 21, 2023 09:52
@johnynek
Copy link

@dwijnand thanks for working on this!

Would you be willing to see if my example works now, and if so add it as a new test case:

#16596 (comment)

@johnynek
Copy link

also, could we add tests with Count[4, Int], Count[5, Int] etc... just to be sure (it surprised me before that small examples worked but bigger didn't).

@dwijnand dwijnand removed the request for review from mbovel June 26, 2023 08:15
@dwijnand dwijnand assigned dwijnand and unassigned mbovel Jun 26, 2023
@dwijnand
Copy link
Member Author

Your summon[Nat.FromInt[3]] was still failing with this change (as well as Count1[3, Int] and greater failing in -Ytest-pickler). So I bit the bullet and finally decided for #18073.

@dwijnand dwijnand closed this Jun 27, 2023
@dwijnand dwijnand deleted the mt/fix-rec-count branch June 27, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursive match type fails after 3rd call when using explicit type
3 participants