Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate releases to SDKMAN #13885

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Automate releases to SDKMAN #13885

merged 3 commits into from
Nov 30, 2021

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Nov 5, 2021

Based on discussion in #782 I added new workflow Releases to automate releases to SDKMAN. This flow have to be trigger manually after official scala release.

It's no trigger automatically due to issues observed at scala-steward-org/scala-steward#1104..

Thanks @julienrf for adding two secrets SDKMAN_KEY and SDKMAN_TOKEN in the dotty repository.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lwronski!

I have left a few comments. I think we should also add a step in the checklist (e.g., within the category “Announce the release”, at the bottom).

@julienrf julienrf assigned lwronski and unassigned julienrf Nov 8, 2021
@lwronski lwronski requested a review from julienrf November 15, 2021 18:51
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Łukas, that looks good to me, I have just left one suggestion regarding the documentation of the script.

@lwronski lwronski requested a review from michelou November 16, 2021 13:40
@julienrf
Copy link
Contributor

julienrf commented Nov 22, 2021

@anatoliykmetyuk Are there any blockers to merge this PR?

@julienrf julienrf merged commit 51828cc into scala:master Nov 30, 2021
@julienrf
Copy link
Contributor

Thank you Łukas!

@marc0der
Copy link

@julienrf please let me know when you plan to do your first release so I can keep an eye out that all goes well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants