Two additions to batch files #13790
Merged
Two additions to batch files #13790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philwalk would you also take a look? I know you test a lot on Windows |
anatoliykmetyuk
approved these changes
Oct 22, 2021
|
@smarter Backport candidate to 3.1.1-RC2. |
|
Does this fix a regression from a previous scala 3 release? Otherwise it's unlikely to be backported. |
|
@smarter My reasoning is as follows :
In other words the feature "batch files support installation path containing spaces"
The final decision is yours. |
|
I'm not familiar with this code so I shouldn't decide really :). You can submit a backport and have @anatoliykmetyuk decide since he reviewed this PR already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additions are follow-ups of the two merged pull requests :
dist/bin/scalac.bat, see PR#13759.dist/bin/scaladoc.bat, see PR#13577.The changes are Windows-specific and have no impact on the CI build.