Skip to content

Commit

Permalink
Temporary fix to CompletionScalaCliSuite (#21564)
Browse files Browse the repository at this point in the history
The [release of `circe/circe` version 0.14.10
yesterday](https://index.scala-lang.org/circe/circe/artifacts/circe-core/0.14.10)
broke the tests. This is just a temporary fix as imo, we should not have
any external dependencies in this repository. The policy for testing to
be defined.

[test_java8]
[test_scala2_library_tasty]

Closes #21561
  • Loading branch information
hamzaremmal authored Sep 7, 2024
2 parents 67cd3eb + c361d7e commit 614170f
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,19 @@ class CompletionScalaCliSuite extends BaseCompletionSuite:

@Test def `version` =
check(
"""|//> using lib "io.circe::circe-core_sjs1:0.14.1@@"
"""|//> using lib "io.circe::circe-core_sjs1:0.14.10@@"
|package A
|""".stripMargin,
"0.14.1"
"0.14.10"
)

// We don't to add `::` before version if `sjs1` is specified
@Test def `version-edit` =
checkEdit(
"""|//> using lib "io.circe::circe-core_sjs1:0.14.1@@"
"""|//> using lib "io.circe::circe-core_sjs1:0.14.10@@"
|package A
|""".stripMargin,
"""|//> using lib "io.circe::circe-core_sjs1:0.14.1"
"""|//> using lib "io.circe::circe-core_sjs1:0.14.10"
|package A
|""".stripMargin,
)
Expand Down

0 comments on commit 614170f

Please sign in to comment.