Skip to content

Commit

Permalink
Remove double tests of tests/pos (#18683)
Browse files Browse the repository at this point in the history
We should not tests all `tests/pos` files twice with another set of
flags. Furthermore, in all our tests the result of adding the flags is
not checked in any meaningful way. The only tests for this flag
(tests/neg-custom-args/fatal-warnings/i17612b/i17612b.scala) does add
the flag explicitly and checks the result already.

See
46f2db6
  • Loading branch information
bishabosha authored Oct 12, 2023
2 parents ef28cd6 + b8aae69 commit 242ba21
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion compiler/test/dotty/tools/dotc/CompilationTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class CompilationTests {
compileFilesInDir("tests/pos", defaultOptions.and("-Ysafe-init")),
compileFilesInDir("tests/pos-deep-subtype", allowDeepSubtypes),
compileFilesInDir("tests/pos-special/sourcepath/outer", defaultOptions.and("-sourcepath", "tests/pos-special/sourcepath")),
compileFilesInDir("tests/pos", defaultOptions.and("-Xlint:private-shadow", "-Xlint:type-parameter-shadow")),
compileFile("tests/pos-special/sourcepath/outer/nested/Test4.scala", defaultOptions.and("-sourcepath", "tests/pos-special/sourcepath")),
compileFilesInDir("tests/pos-scala2", defaultOptions.and("-source", "3.0-migration")),
compileFilesInDir("tests/pos-custom-args/captures", defaultOptions.and("-language:experimental.captureChecking")),
Expand Down

0 comments on commit 242ba21

Please sign in to comment.