Revert "make RegexParser.err handle whitespace like literal and regex." #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gourlaysama
added a commit
that referenced
this pull request
Dec 15, 2014
Revert "make RegexParser.err handle whitespace like literal and regex."
|
Could you please say as to why it's not binary compatible with I didn't understand this part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30 (dc9e9cf), because it isn't binary compatible with
1.0.2. Mima did catch it, this was human error (mine).The plan is:
1.0.3gets released with this PR (so without the fix),masterbecomes1.1.0-SNAPSHOTand the fix is reapplied. That version isn't binary compatible with the1.0versions, so it cannot be bundled with 2.11,1.0.xbranches is created for a possible1.0.4, for binary compatible changes.