-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt-scala-module to 3.2.0 #273
Update sbt-scala-module to 3.2.0 #273
Conversation
I know I've seen MiMa failures like these in other repos, but I seem to have forgotten the details here's one of them, they're about generic signatures:
I don't know what we changed in sbt-scala-module that would cause this to crop up. Perhaps an sbt-version-policy bump? I would have expected this to crop up during a Scala 3 version bump, rather than only cropping up now, since the root cause appears to be a change in the Scala 3 compiler. Not sure how to proceed here. We could disable |
ticket-of-record is lightbend-labs/mima#693 but wasn't lightbend-labs/mima#696 supposed to make it so it's okay for a missing generic signature to be filled in? oh but that PR only covers one direction, but we could be doing bidirectional checking here? |
no, the bidirectional hypothesis doesn't apply, we have |
in 0d83ab1 is where we crossed the 3.1.1/3.1.2 boundary and for a while we had this, but then we removed it, so we've been here once before in this repo: -import com.typesafe.tools.mima.core._
-ThisBuild / mimaBinaryIssueFilters ++= Seq(
- ProblemFilters.exclude[IncompatibleSignatureProblem]("*"),
-) but that doesn't help explain why this is cropping up again now. we have:
and aha, 1.0.4 is quite old, it's from 2021 so that explains why we are seeing this now I guess it's not really necessary to fully understand why we weren't seeing it until we upgraded sbt-scala-module, since the current behavior is correct |
maybe it's time to roll 1.0.5, to get the correct signatures out there? 1.0.4 was built by Scala 3.0.2, we could argue that we really ought to be shipping something built with a Scala LTS version, because lord knows what other bugs 3.0.2 had the only code change since 1.0.4 that looks like an actual bugfix is #205, which has been awaiting release since 2021 π |
I think I've talked myself into suppressing, releasing, un-suppressing. embarking on that now |
27627a5
to
72a05fe
Compare
as per #280, the release will be 1.1.0, not 1.0.5 I had to update all of the publishing secrets, of course |
I thought I knew, from painful firsthand experience, every way that Sonatype publishing could possibly go wrong, but this was new one: there seems to have been a transient outage on pgp.mit.edu. Anyway, it did work eventually. log: https://github.com/scala/scala-parallel-collections/actions/runs/12385019786/job/34571074461 |
About this PR
π¦ Updates org.scala-lang.modules:sbt-scala-module from
3.1.0
to3.2.0
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: