Fixes for akka rewrite #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
added a commit
to MasseGuillaume/akka
that referenced
this pull request
Jul 17, 2018
ran scalafix scala:fix.CrossCompat test:scalafix scala:fix.CrossCompat with scala/scala-collection-compat#100
julienrf
reviewed
Jul 18, 2018
|
|
||
| object LinearSeqSrc { | ||
| LinearSeq(1) | ||
| } |
There was a problem hiding this comment.
We should still support this case
There was a problem hiding this comment.
There was a problem hiding this comment.
Still, I don’t understand why we remove it. We should leave it and improve/fix it later.
There was a problem hiding this comment.
No, if it's incorrect we should remove it. I'm using it to migrate akka, if we keep this rewrite in It's not possible to use scala-collection-compat to rewrite code.
| @@ -45,17 +45,21 @@ trait Stable212Base extends CrossCompatibility { self: SemanticRule => | |||
| val traversable = exact( | |||
| "_root_.scala.package.Traversable#", | |||
| "_root_.scala.collection.Traversable#", | |||
| "_root_.scala.package.Iterable#", | |||
| "_root_.scala.collection.Iterable#" | |||
There was a problem hiding this comment.
we use this to detect if we need to add the compat import for
ctx.replaceSymbols(
"scala.Traversable" -> "scala.Iterable",
"scala.collection.Traversable" -> "scala.collection.Iterable"
)It was incorrectly adding compat import.
| val linearSeqToList = | ||
| ctx.replaceSymbols( | ||
| "scala.collection.LinearSeq" -> "scala.collection.immutable.List", | ||
| ) |
There was a problem hiding this comment.
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #87
With those changes, we can run the CrossCompat on Akka and compile the code without warning/errors and pass all the test.
Diff here:
MasseGuillaume/akka@279fa62