Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Scala 3.4.0 until it's announced #3285

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

rtyley
Copy link
Contributor

@rtyley rtyley commented Feb 14, 2024

We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional, as there are no GitHub release notes for 3.4.0?

See also #2337 & #1104.

cc @Kordyjan

We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional?

guardian/play-secret-rotation#432

See also scala-steward-org#2337 & scala-steward-org#1104
Comment on lines +34 to 39
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.3.2" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.3.2" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.2" } },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there's a more concise way to express these lines? eg

Suggested change
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.0" } },
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.3.2" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.3.2" } },
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.2" } },
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]},
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]},
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]},

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f8ea30) 91.19% compared to head (9b0aaad) 91.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3285   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         167      167           
  Lines        3408     3408           
  Branches      304      304           
=======================================
  Hits         3108     3108           
  Misses        300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kordyjan
Copy link
Contributor

Thank you for spotting that!

Scala Steward should never update from LTS to not-LTS. I thought this would become a problem only with 3.4.1 as there will be two paths for upgrading (3.4.0 -> 3.4.1 and 3.3.2 -> 3.3.3). I completely missed that it will start with 3.4.0. I think the solution is elegant.

@rtyley
Copy link
Contributor Author

rtyley commented Feb 14, 2024

Scala Steward should never update from LTS to not-LTS

I think that's a good rule, but I'm not sure if it will be respected by Scala Steward at the moment - I don't think Scala Steward currently has any conception of Scala LTS releases...

I wonder: what is the correct configuration here when 3.4.0 is released? We might want to update this configuration to ignore both 3.4.0 & 3.4.1... but then when 3.4.1 is released, you can't configure 3.4.1 to be ignored any longer (users of 3.4.0 should upgrade) - and at that point, I'm uncertain if Scala Steward would hold back on recommending an update from Scala 3.3 to 3.4.1.

Another relevant issue is #3153, with commentary from @mzuehlke.

@mzuehlke mzuehlke merged commit 752757f into scala-steward-org:main Feb 14, 2024
6 checks passed
@mzuehlke
Copy link
Member

I wonder: what is the correct configuration here when 3.4.0 is released? We might want to update this configuration to ignore both 3.4.0 & 3.4.1... but then when 3.4.1 is released, you can't configure 3.4.1 to be ignored any longer (users of 3.4.0 should upgrade) - and at that point, I'm uncertain if Scala Steward would hold back on recommending an update from Scala 3.3 to 3.4.1.

I guess without additional logic Scala Steward doesn't know about the concept of an LTS. maybe @fthomas has a good ies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants