-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Scala 3.4.0 until it's announced #3285
Conversation
We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional? guardian/play-secret-rotation#432 See also scala-steward-org#2337 & scala-steward-org#1104
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.4.0" } }, | ||
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.4.0" } }, | ||
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.0" } }, | ||
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.3.2" } }, | ||
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.3.2" } }, | ||
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.2" } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's a more concise way to express these lines? eg
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.4.0" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.4.0" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.4.0" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.3.2" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = { exact = "3.3.2" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { exact = "3.3.2" } }, | |
{ groupId = "org.scala-lang", artifactId = "scala3-compiler", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]}, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]}, | |
{ groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = [ { exact = "3.4.0" }, { exact = "3.3.2" } ]}, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
=======================================
Coverage 91.19% 91.19%
=======================================
Files 167 167
Lines 3408 3408
Branches 304 304
=======================================
Hits 3108 3108
Misses 300 300 ☔ View full report in Codecov by Sentry. |
Thank you for spotting that! Scala Steward should never update from LTS to not-LTS. I thought this would become a problem only with 3.4.1 as there will be two paths for upgrading ( |
I think that's a good rule, but I'm not sure if it will be respected by Scala Steward at the moment - I don't think Scala Steward currently has any conception of Scala LTS releases... I wonder: what is the correct configuration here when 3.4.0 is released? We might want to update this configuration to ignore both 3.4.0 & 3.4.1... but then when 3.4.1 is released, you can't configure 3.4.1 to be ignored any longer (users of 3.4.0 should upgrade) - and at that point, I'm uncertain if Scala Steward would hold back on recommending an update from Scala 3.3 to 3.4.1. Another relevant issue is #3153, with commentary from @mzuehlke. |
I guess without additional logic Scala Steward doesn't know about the concept of an LTS. maybe @fthomas has a good ies |
We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional, as there are no GitHub release notes for 3.4.0?
See also #2337 & #1104.
cc @Kordyjan