This repository was archived by the owner on Sep 15, 2023. It is now read-only.
Fix "View On Explorer" link from within the desktop electron wallet #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "view on explorer" URL link from within desktop wallet. It's currently "tx?tx_info=" which causes a 500, needs to go to "tx.html?hash="
Update backend.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the link is "tx?tx_info=", it needs to be "tx.html?hash=", otherwise it is causing a 500 on the explorer.
Example: link generated from wallet currently: https://explorer.scalaproject.io/tx?tx_info=f5d67c8abf4998fa896e2c98c4c991d991986d003e51e1898a03bd80560623cf
Link generated with this fix: https://explorer.scalaproject.io/tx.html?hash=f5d67c8abf4998fa896e2c98c4c991d991986d003e51e1898a03bd80560623cf