Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicated slashes #28

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: duplicated slashes #28

merged 1 commit into from
Feb 13, 2024

Conversation

jkugiya
Copy link
Contributor

@jkugiya jkugiya commented Dec 28, 2019

Fixes this

@joprice
Copy link

joprice commented Aug 24, 2021

Any way this could get merged? I'm relying on @jkugiya's fork for now.

@mkurz mkurz mentioned this pull request Feb 13, 2024
Closed
@mkurz mkurz force-pushed the fix/duplicated_slashes branch from 82b33e7 to ce1751f Compare February 13, 2024 14:37
@mkurz
Copy link
Member

mkurz commented Feb 13, 2024

I see there is still a problem regarding double slashes:

  1. go to https://www.scala-sbt.org/sbt-paradox-material-theme
  2. type "getting" into the search field and switch to the getting started page
  3. you end up with an url containing two slashed: https://www.scala-sbt.org/sbt-paradox-material-theme//getting-started.html

Let's merge this and see if things improve.

@mkurz mkurz merged commit 59eda71 into sbt:main Feb 13, 2024
5 checks passed
@mkurz
Copy link
Member

mkurz commented Feb 13, 2024

yep, that fixed it. Thanks @jkugiya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 on search_index.json
3 participants
@jkugiya @joprice @mkurz