Adding a describedVersion(...) for ConsoleGitReadableOnly #238
Conversation
There was a problem hiding this comment.
In monorepos (in this example guardrail), the same ref will occasionally have multiple tags.
Relying on
git describewithout--matchcould resolve the wrong tag for different modules.
Nice. I noticed when testing that when there is a release version (v1.2.3) that will still take precedence over the 'described' version, which was surprising to me consistent with the JGit behavior.
Unfortunately JGit still does not support git worktree (though that seems to be coming soon!), so I'm stuck on CLI git.
I like your optimism ;)
See sbt/sbt-git#238. Until that is released, we need to use JGit for correct module versions. See JGit: cli, Some(0.71.0-474-g55ddd1d-SNAPSHOT) core, Some(0.75.3-278-g55ddd1d-SNAPSHOT) java-async-http, Some(0.72.0-376-g55ddd1d-SNAPSHOT) java-dropwizard, Some(0.72.0-376-g55ddd1d-SNAPSHOT) java-spring-mvc, Some(0.71.2-367-g55ddd1d-SNAPSHOT) java-support, Some(0.73.1-367-g55ddd1d-SNAPSHOT) microsite, None scala-akka-http, Some(0.76.0-259-g55ddd1d-SNAPSHOT) scala-dropwizard, Some(0.72.0-376-g55ddd1d-SNAPSHOT) scala-http4s, Some(0.76.1-160-g55ddd1d-SNAPSHOT) scala-support, Some(0.75.3-261-g55ddd1d-SNAPSHOT) vs console git: cli, Some(scala-http4s-v0.76.1-162-ge343b804) core, Some(scala-http4s-v0.76.1-162-ge343b804) java-async-http, Some(scala-http4s-v0.76.1-162-ge343b804) java-dropwizard, Some(scala-http4s-v0.76.1-162-ge343b804) java-spring-mvc, Some(scala-http4s-v0.76.1-162-ge343b804) java-support, Some(scala-http4s-v0.76.1-162-ge343b804) microsite, Some(scala-http4s-v0.76.1-162-ge343b804) scala-akka-http, Some(scala-http4s-v0.76.1-162-ge343b804) scala-dropwizard, Some(scala-http4s-v0.76.1-162-ge343b804) scala-http4s, Some(0.76.1-162-ge343b804) scala-support, Some(scala-http4s-v0.76.1-162-ge343b804)
|
I'm very sorry to bother, what's the release cycle look like for sbt-git? For the time being I've bumped back over to JGit since this issue was preventing useful snapshot releases (it was resolving against the wrong root tag). If there's anything I can do to assist here I'm happy to do it, I'm happy to give back to the SBT org 😊 |
|
Thank you for the PR — apparently nobody was minding the shop here. But I'm sure we'll do a release soon in order to ship #248. |
|
🎉 thanks Seth |
Worktree read support landed in jgit 7, more links here. |
In monorepos (in this example guardrail), the same ref will occasionally have multiple tags.
Relying on
git describewithout--matchcould resolve the wrong tag for different modules.Unfortunately JGit still does not support git worktree (though that seems to be coming soon!), so I'm stuck on CLI git.
Thank you