Use provider.getStackName method to get stackname #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aregier
reviewed
Aug 17, 2018
| this.serverless.service.getServiceName(), | ||
| this.serverless.getProvider('aws').getStage() | ||
| ) | ||
| return this.serverless.getProvider('aws').naming.getStackName() |
There was a problem hiding this comment.
I've seen this same behavior, too. Out of curiosity, why not just read directly from the property (e.g. this.serverless.getProvider('aws').stackName) and declare that in the typings file?
This this value be populated if the stackName property is not set in serverless.yml? It's possible that we need to fall back to the defaulted value here?
There was a problem hiding this comment.
nm; It looks like it is fine even if stackName is not specified in serverless.yml
|
I apparently missed somethings but it seams to be fixed. Any plan to merge this? |
|
+1, just hit this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15