Fix failing tutorials, change MNLE default for log_transform to False #1367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to detecting NaNs in all losses already payed off: In MNLE, we were using the
log_transform=True
per default. This was performing better and makes sense for positive data like reaction times in decision-making experiments. However, it does not make sense in general. In implemented methods tutorial we were passing Gaussian data, which then caused NaNs after the log-transform, causing the loss to become NaN.This PR
False
and add small improvements to the tutorial notebook.main
tests failing)@manuelgloeckler / @michaeldeistler can you have a look please?