Skip to content

Commit

Permalink
🐛 Don't use NodeLocalDNS addon (knative#257)
Browse files Browse the repository at this point in the history
* Don't use NodeLocalDNS and use production GKE API instead of beta

* Ensure the kubetest2 is installed and available in the PATH.
  • Loading branch information
cardil authored Nov 22, 2022
1 parent 2e610ce commit 6397aac
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 0 additions & 4 deletions e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,6 @@ function initialize() {
shift
done

if [[ "${CLOUD_PROVIDER}" == "gke" ]]; then
custom_flags+=("--addons=NodeLocalDNS")
fi

readonly SKIP_DUMP_ON_FAILURE
readonly TEARDOWN
readonly CLOUD_PROVIDER
Expand Down
6 changes: 6 additions & 0 deletions infra-library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ function create_gke_test_cluster() {
if [[ "${ENABLE_PREEMPTIBLE_NODES:-}" == "true" ]]; then
extra_gcloud_flags="${extra_gcloud_flags} --preemptible"
fi
if ! command -v kubetest2 >/dev/null; then
tmpbin="$(mktemp -d)"
echo "kubetest2 not found, installing in temp path: ${tmpbin}"
GOBIN="$tmpbin" go install sigs.k8s.io/kubetest2/...@latest
export PATH="${tmpbin}:${PATH}"
fi
run_kntest kubetest2 gke "${_custom_flags[@]}" \
--test-command="${_test_command[*]}" \
--extra-gcloud-flags="${extra_gcloud_flags}"
Expand Down
1 change: 0 additions & 1 deletion test/unit/presubmit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ func TestMainFunc(t *testing.T) {
"--enable-workload-identity --cluster-version=latest "+
"--extra-gcloud-flags --enable-stackdriver-kubernetes "+
"--no-enable-ip-alias --no-enable-autoupgrade "+
"--addons=NodeLocalDNS "+
"--test-command=%s/test/e2e-tests.sh "+
"--run-tests --extra-gcloud-flags= --logging=NONE "+
"--monitoring=NONE", rootDir)),
Expand Down

0 comments on commit 6397aac

Please sign in to comment.