Skip to content

Commit

Permalink
Remove types array proxy for memories > 4G
Browse files Browse the repository at this point in the history
The upstream issue with chrome was fixed so this proxy should no longer
be needed.
  • Loading branch information
sbc100 committed Nov 15, 2023
1 parent 9429b48 commit f81d047
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 165 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ commands:
description: "install canary version of node"
steps:
- install-node-version:
node_version: "21.0.0-v8-canary202309143a48826a08"
node_version: "22.0.0-v8-canary20231108ff311d5a39"
canary: true
install-v8:
description: "install v8 using jsvu"
Expand Down
4 changes: 0 additions & 4 deletions src/preamble.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,10 @@ function updateMemoryViews() {
#if SUPPORT_BIG_ENDIAN
Module['HEAP_DATA_VIEW'] = HEAP_DATA_VIEW = new DataView(b);
#endif
#if MEMORY64 && MAXIMUM_MEMORY > FOUR_GB
#include "runtime_view_proxy.js"
#else
Module['HEAP8'] = HEAP8 = new Int8Array(b);
Module['HEAP16'] = HEAP16 = new Int16Array(b);
Module['HEAPU8'] = HEAPU8 = new Uint8Array(b);
Module['HEAPU16'] = HEAPU16 = new Uint16Array(b);
#endif
Module['HEAP32'] = HEAP32 = new Int32Array(b);
Module['HEAPU32'] = HEAPU32 = new Uint32Array(b);
Module['HEAPF32'] = HEAPF32 = new Float32Array(b);
Expand Down
4 changes: 0 additions & 4 deletions src/preamble_minimal.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,10 @@ function updateMemoryViews() {
#if SUPPORT_BIG_ENDIAN
{{{ maybeExport('HEAP_DATA_VIEW') }}} HEAP_DATA_VIEW = new DataView(b);
#endif
#if MEMORY64 && MAXIMUM_MEMORY > FOUR_GB
#include "runtime_view_proxy.js"
#else
{{{ maybeExport('HEAP8') }}} HEAP8 = new Int8Array(b);
{{{ maybeExport('HEAP16') }}} HEAP16 = new Int16Array(b);
{{{ maybeExport('HEAPU8') }}} HEAPU8 = new Uint8Array(b);
{{{ maybeExport('HEAPU16') }}} HEAPU16 = new Uint16Array(b);
#endif
{{{ maybeExport('HEAP32') }}} HEAP32 = new Int32Array(b);
{{{ maybeExportIfAudioWorklet('HEAPU32') }}} HEAPU32 = new Uint32Array(b);
{{{ maybeExportIfAudioWorklet('HEAPF32') }}} HEAPF32 = new Float32Array(b);
Expand Down
156 changes: 0 additions & 156 deletions src/runtime_view_proxy.js

This file was deleted.

0 comments on commit f81d047

Please sign in to comment.