Fix for flag added to wrong test_embind in emscripten-core#20758 (ems…

…cripten-core#20760)
sbc100 · Nov 21, 2023 · 8a7ed56 · 8a7ed56
1 parent 527b10e
commit 8a7ed56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/test/test_core.py b/test/test_core.py
@@ -7649,9 +7649,6 @@ def test2():
   })
   def test_embind(self, args):
     self.maybe_closure()
-    # This test explicitly creates std::string from unsigned char pointers
-    # which is deprecated in upstream LLVM.
-    self.emcc_args.append('-Wno-deprecated-declarations')
     create_file('test_embind.cpp', r'''
       #include <stdio.h>
       #include <emscripten/val.h>

diff --git a/test/test_other.py b/test/test_other.py
@@ -2923,6 +2923,9 @@ def test_embind_closure_no_dynamic_execution(self):
   })
   def test_embind(self, *extra_args):
     self.emcc_args += [
+      # This test explicitly creates std::string from unsigned char pointers
+      # which is deprecated in upstream LLVM.
+      '-Wno-deprecated-declarations',
       '-lembind',
       '-sRETAIN_COMPILER_SETTINGS',
       '-sEXPORTED_RUNTIME_METHODS=getCompilerSetting',