Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to pass ruff checks #622

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fixes to pass ruff checks #622

merged 2 commits into from
Jan 31, 2024

Conversation

fnmeyer
Copy link

@fnmeyer fnmeyer commented Dec 22, 2023

Description

-Added explicit ruff checks to mimic previous setup -updated pre-commit versions
-fixed items that didn't pass ruff's checks

main:
-restructure logic to reduce indentation

amazon/amazon_client:
-replace crypto functions with stronger ones

amazon/invoice_parser:
-add "cleaned_text" variable to eliminate rewriting of loop variable

engine/matcher/patcher:
-simplify logic

ynab/ynab_client:
-replace http status constant
-rename budget_id since it isn't used

Misc:
-import sort order
-remove non-specific noqas, replace with specific if still needed
-if except is pass, use contextlib.suppress

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to
    change)
  • 🔐 Security fix

Checklist

  • I've read the
    CODE_OF_CONDUCT.md
    document.
  • I've read the
    CONTRIBUTING.md
    guide.
  • I've updated the code style using make codestyle.
  • make codestyle no longer applicable?
  • I've written tests for all new methods and classes that I created.
  • didn't add any new methods or classes
  • I've written the docstring in Google format for all the methods and classes that used.
  • didn't add any new methods or classes

-Added explicit ruff checks to mimic previous setup
-updated pre-commit versions
-fixed items that didn't pass ruff's checks

__main__:
    -restructure logic to reduce indentation

amazon/amazon_client:
    -replace crypto functions with stronger ones

amazon/invoice_parser:
    -add "cleaned_text" variable to eliminate rewriting of loop variable

engine/matcher/patcher:
    -simplify logic

ynab/ynab_client:
    -replace http status constant
    -rename budget_id since it isn't used

Misc:
    -import sort order
    -remove non-specific noqas, replace with specific if still needed
    -if except is pass, use contextlib.suppress
@sbarrios93 sbarrios93 merged commit ee5b6d7 into sbarrios93:v2 Jan 31, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants