-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding theme configuration for output and guideline practices and other proposals #20
Open
wilmeragsgh
wants to merge
49
commits into
sb2nov:master
Choose a base branch
from
wilmeragsgh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing typo in overleaf url
Formatting preview in row for readability
Updating preview images to match sizing
Adding guidelines provided by used references on structure.
Adding small documentation for switching themes.
Trying small improvement in README.md structure
Finishing initial version of the readme.
Adding acknowledgments section
Adding url to sb2nov profile
…ing spacing between courses credentials
…nks for understanding that sections are clickable and final note when is not clickable anymore
…ramming tools visibility
…ce Models certificate
Update spelling found in README Thanks for the corrections, I do hope it helps more people and that would definitely help giving it visibility!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I hope you're doing well in this complex time.
First of all, I wanted to thank you for the initial code as it helped me in getting ready again for the job search process as I couldn't continue where I worked for COVID-19 logistic issues.
That said, I want to propose you adding the following:
Themes for output: As I think people read mostly digitally anyway it could be more readable if we include it right in the output.
Adding references for up-to-date versions of the URL: So if anyone has a legacy version it can go to the latest one anytime.
Adding guidelines for structuring the entries: I was looking for some recommendations and found those to make sense and also to be trustable.
Switching from project name to a milestone achieved approach: This as one of the recommendations in the guidelines and also to make it difficult to be vague while using the template, which I think could help other people.
That's it, let me know what you think, and thanks again! 👋