Fixes rsyslog.conf for rhel < 7 and puppet >=4 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to puppet docs, to test for undef in erb template, you should use nil (https://puppet.com/docs/puppet/4.10/lang_template_erb.html#scopevariable-or-scopelookupvarvariable)
See also this bug https://tickets.puppetlabs.com/browse/PUP-1467 which basically says with puppet 4 you should be using nil to test for undef, not :undef.
By using :undef, my puppet 4 rhel < 7 clients have the following options created in rsyslog.conf with blank values - causing rsyslog to error
(the last error occured in /etc/rsyslog.conf, line 41:"$imjournalIgnorePreviousMessages ")when trying to read the configuration file: