Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate static factory methods, closes #178 #179

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

dmfs
Copy link
Collaborator

@dmfs dmfs commented Apr 2, 2024

No description provided.

@dmfs dmfs force-pushed the 178-relocate-factory-methods branch from a673210 to a4a2d3e Compare April 2, 2024 16:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.53%. Comparing base (8ecf4c4) to head (bc68d98).

Files Patch % Lines
...rg/saynotobugs/confidence/json/quality/Number.java 0.00% 1 Missing ⚠️
...rg/saynotobugs/confidence/json/quality/Object.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #179      +/-   ##
============================================
- Coverage     97.78%   96.53%   -1.26%     
+ Complexity      845      838       -7     
============================================
  Files           217      218       +1     
  Lines          1855     1876      +21     
  Branches         59       59              
============================================
- Hits           1814     1811       -3     
- Misses           32       55      +23     
- Partials          9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmfs dmfs force-pushed the 178-relocate-factory-methods branch from a4a2d3e to ae73bf0 Compare April 2, 2024 16:20
@dmfs dmfs merged commit 496c5ca into main Apr 5, 2024
1 of 3 checks passed
@dmfs dmfs deleted the 178-relocate-factory-methods branch April 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants