unsafeInstanceOf Quality, closes #155 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmfs
commented
Dec 28, 2023
| @@ -43,7 +43,7 @@ | |||
|
|
|||
|
|
|||
| @StaticFactories(value = "Core", packageName = "org.saynotobugs.confidence.quality") | |||
| public final class Iterates<T> implements Quality<Iterable<T>> | |||
| public final class Iterates<T> implements Quality<Iterable<? extends T>> | |||
There was a problem hiding this comment.
ups, this should be reverted
dmfs
force-pushed
the
155-unsafeInstanceOf
branch
from
714beb4
to
26050c4
Compare
This provides a Quality similar to `istanceOf` but also taking `Quality`s of subclasses of the given class. This is unsafe because there is no guarantee that the testee is actually of that subtype, but it may be required if the testee is a generic class. It solves issues like described in hamcrest/JavaHamcrest#388
dmfs
force-pushed
the
155-unsafeInstanceOf
branch
from
26050c4
to
f6da1cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=========================================
Coverage 97.71% 97.71%
- Complexity 820 821 +1
=========================================
Files 212 213 +1
Lines 1791 1793 +2
Branches 56 56
=========================================
+ Hits 1750 1752 +2
Misses 31 31
Partials 10 10 ☔ View full report in Codecov by Sentry. |
saynotobugsorg
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a Quality similar to
istanceOfbut also takingQualitys of subclasses of the given class. This is unsafe because there is no guarantee that the testee is actually of that subtype, but it may be required if the testee is a generic class.It solves issues like described in
hamcrest/JavaHamcrest#388