Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertionThat generic argument, fixes #99 #100

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

dmfs
Copy link
Collaborator

@dmfs dmfs commented Aug 23, 2023

The Quality should be contra-variant in T

The Quality should be contra-variant in T
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (9ebc4d6) 97.15% compared to head (9d6df3b) 97.01%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #100      +/-   ##
============================================
- Coverage     97.15%   97.01%   -0.15%     
  Complexity      628      628              
============================================
  Files           163      163              
  Lines          1372     1374       +2     
  Branches         47       47              
============================================
  Hits           1333     1333              
- Misses           33       35       +2     
  Partials          6        6              
Files Changed Coverage Δ
...fidence/junit5/engine/assertion/AssertionThat.java 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmfs dmfs merged commit e801a3f into main Aug 23, 2023
1 check passed
@dmfs dmfs deleted the 99-improve-assertionThat branch August 23, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants