Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing not found error #47

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rettinghaus
Copy link
Member

adds a function to return the correct GND-IDN for a processes record.
fixes #21

NB: maybe another place for that addition is better, as it also should do the trick for persons?

@rettinghaus
Copy link
Member Author

pinging @ukretschmer

@ukretschmer
Copy link
Member

Thnx for pinging @rettinghaus . Two things to think of:

  1. As I see now, you are doing e new request for each result. Is there really no other way? If we got 10 results, this function will call the details of every result in a single request :/
  2. Yes, there should be a better place for the function. Maybe we should provide a small "library" with viaf-specific functions for those using viaf as search interface, also for persons, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIAF returns wrong IDs
2 participants