Feature/notifications page #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added logic to set loading bar state on long press objects notifications.page.scss -added conditional css to animate a loading bar when loading bar state is set to true.
notifications.page.scss
…tribe-app-frontend into feature/notifications-page
-Started over and used ionic progress-bar -added a method to store progress to model serivce -added input option to notificatation serivce to work directly with the notificaiton savvatos.developer.ts -experienced soul crushing debugging and truth finding -swallowed pride and implemented alternative routes notifications.model.service.ts -add key:value pair to notifications in the form of progress and 0 -added function to init to set value of progress to 0 for each notificaiton -added method to retrieve progress notifications.page.html -bonded progress from notification to populate progress bar -added conditional check to not load progressbar when not deleteing notification notifications.page.scss -removed old scss and added scss to progress bar to remain hidden when not in use notifications.page.ts -added method to receive progress from model service -added funciton to enable progress bar when progress reaches 1%
Increased sensitivity of "isNotificationProgressed" by decreasing the conditional from .1 to .01.
haxwell
merged commit 14d4f4b
into
savvato-software:feature/notifications-page
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS upgrades