refactor: Optimize dockerfiles for production images #4302
Merged
+180
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Nice trick on the multistage images, we wrote them long time ago when this wasn't available, it's great to see it used now. |
vitoyucepi
force-pushed
the
refactor/dockerfiles
branch
from
876a911 to
69400c9
Compare
vitoyucepi
commented
Jan 7, 2025
|
Where should containers be pushed to? - name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Login to GitHub Container Registry
uses: docker/login-action@v3
if: needs.build_details.outputs.publish_docker_image == 'true'
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }} - name: Login to container registries
run: |
echo "${{ secrets.DOCKERHUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKERHUB_USER }}" --password-stdin
echo "${{ secrets.GITHUB_TOKEN }}" | docker login -u "${{ github.actor }}" --password-stdin ghcr.io |
auto-merge was automatically disabled
January 8, 2025 04:56
Head branch was pushed to by a user without write access
vitoyucepi
changed the title
vitoyucepi
changed the title
vitoyucepi
force-pushed
the
refactor/dockerfiles
branch
5 times, most recently
from
b2c29f9 to
9b987be
Compare
toots
reviewed
Jan 8, 2025
vitoyucepi
force-pushed
the
refactor/dockerfiles
branch
from
9b987be to
880b42e
Compare
Create a separate stage to download files and mount it as a volume later. Remove tini as it's not needed to run liquidsoap as main process. Use RUN syntax similar to that used for official images. Remove apt lists from the resulting Debian container images.
Replace the build-docker.sh script with a GitHub action to standardize the ci workflow and reduce complexity.
vitoyucepi
force-pushed
the
refactor/dockerfiles
branch
from
880b42e to
6204a1e
Compare
|
@toots, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Dockerfiles by creating smaller production images.
Details
ADD,COPY, and download files.tiniprocess manager because it is unnecessary to run Liquidsoap as the main process. Also, some Debian dependencies, such asexim, are not installed due to--no-install-recommends.RUNsyntax that matches official images, making the Dockerfiles easier to read and understand.Additionally
Size difference:
savonet/liquidsoap-alpine:rolling-release-v2.3.x: from 295MB to 278MBsavonet/liquidsoap:rolling-release-v2.3.x: from 795MB to 697MBRefactored GitHub actions workflow to use docker/login-action and docker/build-push-action instead of
docker loginandbuild-docker.sh.Renamed Dockerfiles:
Dockerfile.productiontodebian.dockerfile;Dockerfile.alpine-productiontoalpine.dockerfile;Dockerfile.websitetowebsite.dockerfile.The list of packages removed from the debian-based image