Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of rolling-release version. #4294

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Fix parsing of rolling-release version. #4294

merged 3 commits into from
Jan 1, 2025

Conversation

smimram
Copy link
Member

@smimram smimram commented Jan 1, 2025

  • allow "rolling-release-v" as prefix to the version
  • consider "x" in the version number as -1

Fixes #4287.

@smimram
Fix parsing of rolling-release version.
9caef8c 
- allow "rolling-release-v" as prefix to the version
- consider "x" in the version number as -1

Fixes #4287.
@smimram smimram requested a review from toots January 1, 2025 12:28
toots
toots reviewed Jan 1, 2025
View reviewed changes
src/lang/lang_string.ml Outdated Show resolved Hide resolved
@toots
Copy link
Member

toots commented Jan 1, 2025

Thanks! I made x be max_int. In most situations, if we say at least version 2.3.4, we expect 2.3.x to be the rolling release above it (and above all released 2.3.* versions..)

@toots toots enabled auto-merge January 1, 2025 18:41
@toots toots added this pull request to the merge queue Jan 1, 2025
Merged via the queue into main with commit 3d4d997 Jan 1, 2025
34 checks passed
@toots toots deleted the rolling-version branch January 1, 2025 19:16
toots added a commit that referenced this pull request Jan 3, 2025
@smimram @toots
Fix parsing of rolling-release version. (#4294)
3ee8506 
Co-authored-by: Romain Beauxis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toots toots toots left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

%ifversion throws an error when using git branch name
2 participants
@smimram @toots