Skip to content

Commit

Permalink
add to R profile
Browse files Browse the repository at this point in the history
  • Loading branch information
@michalovadek
michalovadek committed Nov 19, 2024
1 parent f7c2807 commit be83356
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/R-CMD-check.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,19 @@ jobs:
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes

steps:
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-r@v2
with:
use-public-rspm: true

- name: Add cmdstanr repo
run: |
writeLines('options(repos = c(cmdstanr = "https://stan-dev.r-universe.dev", getOption(\"repos\")))', file("~/.Rprofile", "ab"))
shell: Rscript {0}

- name: Install cmdstanr
run: |
Rscript -e 'install.packages("cmdstanr", repos = c("https://stan-dev.r-universe.dev", getOption("repos")))'
Expand All @@ -55,4 +61,4 @@ jobs:
- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'
build_args: 'c("--no-manual","--no-build-vignettes","--ignore-vignettes")'
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ Encoding: UTF-8
LazyData: true
NeedsCompilation: yes
SystemRequirements: GNU make
Additional_repositories: https://stan-dev.r-universe.dev
VignetteBuilder: R.rsp
RoxygenNote: 7.3.2

6 comments on commit be83356

@saudiwin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having R-CMD check and Github actions set up, but one issue is that I do want this to go to CRAN eventually (probably by year's end or January or so), and for that to happen I'll have to remove the cmdstanr dependency. But it does make sense to leave it in for now -- probably I'll make a CRAN branch when that happens.

@saudiwin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ideally for an R CMD Check we render the file package_test_v2.Rmd as that contains simulations of most models. Even more ideal would be some kind of Rhat output from that file that we can then scan for outliers etc.

But what we have now is a great start for making the package more stable! Thanks!

@michalovadek
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is just to get the ball rolling on CI. Are you not thinking about a testthat (or equivalent) type of setup for your tests? then we should definitely add them to the GH actions

I feel like making this package CRAN-compliant might take a moment :-)

@saudiwin
Copy link
Owner

@saudiwin saudiwin commented on be83356 Nov 19, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saudiwin
Copy link
Owner

@saudiwin saudiwin commented on be83356 Nov 19, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalovadek
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, compliance with CRAN policies -- especially the least important ones -- is incredibly annoying in my experience as well

Please sign in to comment.