martian: log response body close error in connectHTTP

saucelabs · Nov 15, 2023 · 48000e7 · 48000e7
1 parent 6080252
commit 48000e7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/martian/proxy.go b/internal/martian/proxy.go
@@ -954,7 +954,9 @@ func (p *Proxy) connectHTTP(req *http.Request, proxyURL *url.URL) (res *http.Res
 
 	if res != nil {
 		if res.StatusCode/100 == 2 {
-			res.Body.Close()
+			if err := res.Body.Close(); err != nil {
+				log.Errorf(req.Context(), "failed to close CONNECT response body: %v", err)
+			}
 			return proxyutil.NewResponse(200, http.NoBody, req), conn, nil
 		}