Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing parent pom, making all projects independent from each other #260

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

mmerrell
Copy link
Contributor

Have a look...

@mmerrell
Copy link
Contributor Author

@diemol I can't find the note where you talked about setup-java. I'd like to do that as part of a separate branch. Meanwhile, I think I rebased this correctly.

@diemol
Copy link
Member

diemol commented Jan 29, 2025

@mmerrell I think we should stay with Java 11 until Selenium moves to Java 21. Ideally soon.

CI is failing because some paths are not found anymore. Can you please check?

@mmerrell
Copy link
Contributor Author

Ok, all builds are passing now, and things are consistent. I believe the README files are all still correct here, but I'm going to pass through them to improve and update them better. That will be a separate PR

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mmerrell!

Feel free to merge when you think the README is in shape.

@mmerrell mmerrell merged commit 9490331 into main Jan 30, 2025
10 of 11 checks passed
@mmerrell mmerrell deleted the unparent branch January 30, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants