-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SEP-0007 payment requests #1179
Conversation
when it is opened by the PaymentAccountSelectionDialog
Great job, @ebma! 👍 I proposed a wording change and we need to re-arrange the headlines in the view a little bit – looks somewhat unbalanced right now. Otherwise really cool. We should also think about whether it makes sense to show the "trust this origin" dialog before the user has had a chance to see the actual request. Happy to fix this as a separate issue, though. Don't think it should be blocking. |
onClose: () => void | ||
} | ||
|
||
function PaymentAccountSelectionDialog(props: PaymentAccountSelectionDialogProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that we can either refactor right now or we need to do it as soon as we start working on tx
type requests:
It should probably rather be called TransactionRequestReviewDialog
or similar and we should pass that SEP-7 URI content rendered as a grid as children
prop, so we can re-use this component for the tx
type URIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we postpone it until we do the tx
type requests because it might be easier to restructure once we know how we handle/show tx
requests.
Pushed one commit with a few UI adjustments. Btw, why did you prevent the max-width to be set? I thought it looked rather strange on a desktop screen. Maybe you had your reasons, but I changed that as part of my commit. |
Co-authored-by: Andy Wermke <[email protected]>
The |
The onCancel prop was not used before so now it indicates whether the payment form should show a dismiss button or not
4e5e279
to
e133f24
Compare
e133f24
to
abc70ab
Compare
Superseded by #1202. |
transactionRequest
context (to parse and store incoming SEP-0007 requests)<TransactionRequestHandler>
that checks theuri
stored in thetransactionRequest
context and shows dialogs according to its content<VerifyTrustedServiceDialog>
that is shown for incoming SEP-0007 requests that have anorigin_domain
but are not in the list of trusted services. The user can then decide to trust this domain and it will be added to the list of trusted services.<PaymentAccountSelectionDialog>
that is shown for incoming SEP-0007pay
requests. It shows details of the pay request and allows the user to select an account to use for this payment. Only accounts that hold a trustline for the specified asset will be shown in the list. A warning will be shown if the request is not signed. Selecting an account will show the payment dialog for the selected account.preselectedParams
as prop to the<PaymentForm>
to be able to pre-fill the respective input fields with values of thepay
request. Pre-filled input fields will be disabled so that the user cannot change the value.localStorage
in web build (makes it easier to test trusted services but is useful in general)Closes #323.
Preview of the
<PaymentAccountSelectionDialog>
if noorigin_domain
and nosignature
are provided:Flow when
origin_domain
of request is already a trusted service:Flow when
origin_domain
of request is not a trusted service: