Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payment view crashing due to failing stellar.expert fetch #1141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Generic/hooks/stellar-ecosystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export function useTickerAssets(testnet: boolean) {
}

export function useWellKnownAccounts(testnet: boolean) {
let accounts: AccountRecord[]
const [error, setError] = React.useState<Error | undefined>(undefined)
let accounts: AccountRecord[] = []

const forceRerender = useForceRerender()
const fetchAccounts = () => fetchWellknownAccounts(testnet)
Expand All @@ -23,22 +24,24 @@ export function useWellKnownAccounts(testnet: boolean) {
} catch (thrown) {
if (thrown && typeof thrown.then === "function") {
// Promise thrown to suspend component – prevent suspension
accounts = []
thrown.then(forceRerender, trackError)
accounts = []
} else {
// It's an error – re-throw
throw thrown
if (!error || error.message !== thrown.message) {
setError(thrown)
}
}
}

const wellknownAccounts = React.useMemo(() => {
return {
accounts,
error,
lookup(publicKey: string): AccountRecord | undefined {
return accounts.find(account => account.address === publicKey)
}
}
}, [accounts])
}, [accounts, error])

return wellknownAccounts
}