fix(auth): can't sign out #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshuata is attempting to deploy a commit to the satisfactorymodding Team on Vercel. A member of the Team first needs to authorize it. |
|
I may have been incorrect removing the explicit domain specifier. Although they look the same in developer tools, you need to set the domain to pass the cookies to subdomains. I'll quickly patch this. Update: fixed. This should be ready to go |
Fixes satisfactorymodding#131. Explicitly setting the cookie hostname was causing cookie.remove to fail. I cannot fully test this fix since I cannot test oauth on my machine, but I haven't changed any logic so it should be a quick validation.
joshuata
force-pushed
the
joshuata/issue131
branch
from
62da3db to
abdfade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131. Explicitly setting the cookie hostname was causing
cookie.remove to fail.
I cannot fully test this fix since I cannot test oauth on my machine,
but I haven't changed any logic so it should be a quick validation.