chore: match API arch->target changes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The svelte-kit tsconfig has *.ts, and *.svelte by default
…f mod cards, closes #44
* Assorted cleanup (#73) * chore: consistently use tabs in tsconfig.json * docs: suggest running graphql-codegen after changing branches * chore: vscode suggested extensions, start on spellchecker dictionary * chore: link contributing.md from readme since it has setup info also fix indent level * chore: suggest vscode postcss extension * chore: suggest vscode postcss intellisense extension * feat: additional compatibility info details, gray icons if absent (#74) * fix: outdated banner reactivity (#66) * Fixed doggo easter egg typo, #77 (#78) --------- Co-authored-by: mircearoata <[email protected]> Co-authored-by: porisius <[email protected]>
* User-friendly display of target compatibility Changes to solve #68 * made linter happy * Removed unused code, corrected position of pre-dedi comment * Lockfile for iconify, also solved lockfile fail * Fixed implicitly has an 'any' type, * 2x2 Target Chart/Icon, formatting wip * Display mod dependencies as well as link to mod page * Display mod dependencies as well as link to mod page Solves #67 * chore: concise checkTargets function * fix: correct download icon vertical alignment * chore: reduce code duplication in dependency mod links * urlWrap for source and Tag movement/formatting * moar Tag formatting * Removed unused packages * Multi-target/Mod Dependency formatting * made linter happy * Fixed :: on Tags * reformatted target widths * Moved compatibility info and converted it to a Grid * removed Multi Compability, fixed formatting * forgot to lint, sorry * fix: overflowing OutdatedBanner (closes #82) * feat: compatibility icons in grid header * chore: bash script to launch with the right env vars for dev * chore: fix typo it's almost a year old now, I will not allow it to have a happy birthday * feat: compatibility grid display for mods without compatibility info specified * feat: center mod icon on the page when displayed as a full page * feat: compatibility grid as a card * feat: compatibility edit button text changed "Compatibility" -> "Edit Compatibility" * feat: mention markdown support in compatibility edit popup * feat: extra spacing in compatibility viewing popup for improved readability * feat: tooltips for target compatibility icons * feat: display "(No tags assigned)" on mod page tag display when none present instead of empty space * feat: display "(No source URL provided by mod author)" when none present instead of empty space * feat: version target support grid as a component, now also present on View Version page * feat: version dependencies grid as a component, now also WIP present on View Version page ...except that api endpoint doesn't return dependencies yet * Added Multiplayer Compatibility * lint/prettier * Style for Multiplayer Compatbility * Word Wrap Fixes * Version Dependencies Grid GraphQL Fix * Fixed some imports per Mircea's request * Revert "Style for Multiplayer Compatbility" This reverts commit 70f1f8d. * Revert "lint/prettier" This reverts commit 82af767. * Revert "Added Multiplayer Compatibility" This reverts commit 70db911. * Path formatting fixes per Mircea * Fixed formatting paths * Removed casts, replaced with reactive version target support * Removed WindowsNoEditor * break-all Style => Class, removed optional ? for mod on ModInfo * chore: remove script from 7c4ced3 since it's in its own pr now * chore: fixes from code review * Added VersionTarget/VersionDependency to graphql keys config * fixed alignment of icons and text * feat: add sml engine version * chore: format --------- Co-authored-by: Robb <[email protected]> Co-authored-by: Vilsol <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Vilsol
requested review from
mircearoata and
budak7273
and removed request for
mircearoata
mircearoata
approved these changes
Oct 19, 2023
Vilsol
added a commit
that referenced
this pull request
Jan 6, 2024
* fix: more translations * chore: format * chore: address a11y warnings. not sure how to test thoroughly (#99) * chore: match API arch->target changes (#121) * chore: match API arch->target changes * feat: match mod file validation to API's * feat: validate SML version target uniqueness * chore: include all typescript files in tsconfig The svelte-kit tsconfig has *.ts, and *.svelte by default * chore: restore pre-commit hook to pnpm check * feat: make boostrap_version optional * feat: link users to docs page for multi-target format packaging * feat: clarify latest versions section, closes #75 * fix: move ModLatestVersion above ModInfo, closes #79 * feat: make LatestVersions buttons call install via SMM, closes #59 * feat: ctrl-click and Open Link in New Tab support for image element of mod cards, closes #44 * feat: release as default new version stability, closes #76 * chore: match tsconfig from staging a04c199 to fix merge conflicts * chore(dedi): Bring in changes from Staging (#86) * Assorted cleanup (#73) * chore: consistently use tabs in tsconfig.json * docs: suggest running graphql-codegen after changing branches * chore: vscode suggested extensions, start on spellchecker dictionary * chore: link contributing.md from readme since it has setup info also fix indent level * chore: suggest vscode postcss extension * chore: suggest vscode postcss intellisense extension * feat: additional compatibility info details, gray icons if absent (#74) * fix: outdated banner reactivity (#66) * Fixed doggo easter egg typo, #77 (#78) --------- Co-authored-by: mircearoata <[email protected]> Co-authored-by: porisius <[email protected]> * chore: rename WindowsNoEditor to Windows * fix: handle null in trimNonSchema * feat: allow adding targets to SML versions when editing * fix: display SML version target link validation errors * chore: use GQL TargetName enum * feat: target compatibility, mod dependency display (#81) * User-friendly display of target compatibility Changes to solve #68 * made linter happy * Removed unused code, corrected position of pre-dedi comment * Lockfile for iconify, also solved lockfile fail * Fixed implicitly has an 'any' type, * 2x2 Target Chart/Icon, formatting wip * Display mod dependencies as well as link to mod page * Display mod dependencies as well as link to mod page Solves #67 * chore: concise checkTargets function * fix: correct download icon vertical alignment * chore: reduce code duplication in dependency mod links * urlWrap for source and Tag movement/formatting * moar Tag formatting * Removed unused packages * Multi-target/Mod Dependency formatting * made linter happy * Fixed :: on Tags * reformatted target widths * Moved compatibility info and converted it to a Grid * removed Multi Compability, fixed formatting * forgot to lint, sorry * fix: overflowing OutdatedBanner (closes #82) * feat: compatibility icons in grid header * chore: bash script to launch with the right env vars for dev * chore: fix typo it's almost a year old now, I will not allow it to have a happy birthday * feat: compatibility grid display for mods without compatibility info specified * feat: center mod icon on the page when displayed as a full page * feat: compatibility grid as a card * feat: compatibility edit button text changed "Compatibility" -> "Edit Compatibility" * feat: mention markdown support in compatibility edit popup * feat: extra spacing in compatibility viewing popup for improved readability * feat: tooltips for target compatibility icons * feat: display "(No tags assigned)" on mod page tag display when none present instead of empty space * feat: display "(No source URL provided by mod author)" when none present instead of empty space * feat: version target support grid as a component, now also present on View Version page * feat: version dependencies grid as a component, now also WIP present on View Version page ...except that api endpoint doesn't return dependencies yet * Added Multiplayer Compatibility * lint/prettier * Style for Multiplayer Compatbility * Word Wrap Fixes * Version Dependencies Grid GraphQL Fix * Fixed some imports per Mircea's request * Revert "Style for Multiplayer Compatbility" This reverts commit 70f1f8d. * Revert "lint/prettier" This reverts commit 82af767. * Revert "Added Multiplayer Compatibility" This reverts commit 70db911. * Path formatting fixes per Mircea * Fixed formatting paths * Removed casts, replaced with reactive version target support * Removed WindowsNoEditor * break-all Style => Class, removed optional ? for mod on ModInfo * chore: remove script from 7c4ced3 since it's in its own pr now * chore: fixes from code review * Added VersionTarget/VersionDependency to graphql keys config * fixed alignment of icons and text * feat: add sml engine version * chore: format --------- Co-authored-by: Robb <[email protected]> Co-authored-by: Vilsol <[email protected]> * chore: lint * fix: check if state exists * chore: temporarily allow only single-target mods * chore: allow both single-target and multi-target --------- Co-authored-by: mircearoata <[email protected]> Co-authored-by: Robb <[email protected]> Co-authored-by: porisius <[email protected]> * fix: display 'Unknown' instead of nothing when compatibility state is missing (#123) * Unknown compatibility state fixes (#124) * fix: prevent compatibility editor dialog crash when server sends null compatibility state * feat: display "no compatibility info yet" description for unknown compat info mods * chore: helpers to start with correct env vars (#113) * chore: bash script to launch with the right env vars for dev (improved readme after cherry pick from dedis) * chore: use dotenv-flow instead of bash script per linked comment #81 (comment) * chore: dev setup process improvements (#127) * chore: add better error messages to download_translations.sh * chore: setup directions that assume less and cover/avoid common error cases * chore: improved dev sign in steps * NodeJS -> Bun, SMUI -> Skeleton. Depdency updates. (#117) * refactor: node -> bun refactor: smui -> skeleton * refactor: almost fully on skeleton * chore: format chore: fix ci chore: fix docker image * chore: run postinstall for lint * chore: use bash * chore: bump bun version * fix: rewrite tag list to skeleton * chore: bump bun workflow version * chore: update docs to bun * chore: fix run scripts, enable prerender * chore: use bun for sequential scripts * chore: bump deps * fix: fit everything in ficsit card fix: fit button in tables * chore: remove package overrides * feat: prettier 404 page fix: remove old toasts * chore: add devcontainer chore: switch eslint to new config format * chore: gitattributes file for line endings on windows/linux * chore: devcontainer: git safe folder * chore: custom feature, add env bash alias * chore: lint * fix: add required ticks fix: propagate compatibility to dialog fix: increase menu z-index * fix: disable toast on login check * fix: don't purge cookie consent css * chore: formatting * fix: add emoji font * fix: always use emoji font last * fix: convert compatibility to skeleton styles chore: bump bun to 1.0.6 * chore: remove todo * chore: make husky files executable * chore: bump dependencies and bun * fix: resolve graphql version * fix: do not take up full screen with sidebar on mobile --------- Co-authored-by: Rob B <[email protected]> * fix: turn sml version satisfactory version field to number * chore: bump bun to 1.0.11 * fix: stretch card image to full size. Fixes #122 * chore: make cookie consent translatable, but it seems to load before the user's language selection (#98) * chore: make cookie consent translatable, but it seems to load before the user's language selection * chore: delay cookieconsent appearance until tolgee load complete * fix: fix ssr * chore: remove debug * fix: install correct packages * feat: add italian, dutch, russian translations * Update with setup directions for Windows (using cloned-in-volume devcontainer) (#133) * fix: login and logout issues * fix: search default to 0th page * chore: update Windows setup directions + devcontainer extensions (#134) * fix: make mobile-size sidebar close on interact (#135) * chore: extract component sidebar item * fix: make mobile-size sidebar close on interact * chore: silence irrelevant tailwind warning * feat: close compat editor upon saving and reload page to update displayed info (#136) * feat: use Release as default new version stability (#137) * fix: close #59 (#138) * feat: visual indicator for if a mod is hidden (closes #130) (#139) * feat: display warning on unapproved versions (#140) * feat: additional tooltips for mod version navigation and download buttons (#141) * feat: new version page enhancements (#142) * feat: button to return from the New Version page * feat: wip edit compat info on New Version page * fix: new version compat edit incorrect modId * feat: "launcher detected" button to "open mod manager" * feat: pretty button icons, back buttons with confirm prompts * chore: sveltekit 2 (#143) * chore: sveltekit 2 chore: upgrade bun to v1.0.18 chore: bump dependencies chore: lint * fix: bun format erroring on unknown prettier rule file * chore: update devcontainer extensions + suggestions --------- Co-authored-by: Rob B <[email protected]> * feat: display 'None provided' when no source code linked instead of blank (#144) * feat: show target grid if more than one version is uploaded * refactor: tailwind class sorting * feat: simple tag search * fix: align new mod button * chore: remove debug * feat: tag dropdown * fix: show all tags in list * feat: tag descriptions * feat: tag display, search improvements, tag tooltips (#146) * chore: extract component: TagDisplay * chore: replace ambiguous tag-button with Filter button, more translation keys * fix: size of Filter... button * feat: tag description fancy tooltips, show tag description when adding tags to a mod * fix: use correct tag description * fix: fetch tag description on user page * Tag patches (#148) * fix: add spacing at the bottom of the tags collapse section to avoid paginator drawing over tooltips (z index isn't helping for some reason) * fix: remove forced period at end of tag descriptions * chore: switch tag data binding to use tag id * chore: fix hover-tags saying you should click on them in browser title-tooltip * fix: tag popups, paginator position --------- Co-authored-by: Vilsol <[email protected]> Co-authored-by: mircearoata <[email protected]> Co-authored-by: porisius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to solve #68
made linter happy
Removed unused code, corrected position of pre-dedi comment
Lockfile for iconify, also solved lockfile fail
Fixed implicitly has an 'any' type,
2x2 Target Chart/Icon, formatting wip
Display mod dependencies as well as link to mod page
Display mod dependencies as well as link to mod page
Solves #67
chore: concise checkTargets function
fix: correct download icon vertical alignment
chore: reduce code duplication in dependency mod links
urlWrap for source and Tag movement/formatting
moar Tag formatting
Removed unused packages
Multi-target/Mod Dependency formatting
made linter happy
Fixed :: on Tags
reformatted target widths
Moved compatibility info and converted it to a Grid
removed Multi Compability, fixed formatting
forgot to lint, sorry
fix: overflowing OutdatedBanner (closes Long source URLs will offset the compatibility overlay image #82)
feat: compatibility icons in grid header
chore: bash script to launch with the right env vars for dev
chore: fix typo
it's almost a year old now, I will not allow it to have a happy birthday
feat: compatibility grid display for mods without compatibility info specified
feat: center mod icon on the page when displayed as a full page
feat: compatibility grid as a card
feat: compatibility edit button text changed "Compatibility" -> "Edit Compatibility"
feat: mention markdown support in compatibility edit popup
feat: extra spacing in compatibility viewing popup for improved readability
feat: tooltips for target compatibility icons
feat: display "(No tags assigned)" on mod page tag display when none present instead of empty space
feat: display "(No source URL provided by mod author)" when none present instead of empty space
feat: version target support grid as a component, now also present on View Version page
feat: version dependencies grid as a component, now also WIP present on View Version page
...except that api endpoint doesn't return dependencies yet
Added Multiplayer Compatibility
lint/prettier
Style for Multiplayer Compatbility
Word Wrap Fixes
Version Dependencies Grid GraphQL Fix
Fixed some imports per Mircea's request
Revert "Style for Multiplayer Compatbility"
This reverts commit 70f1f8d.
This reverts commit 82af767.
This reverts commit 70db911.
Path formatting fixes per Mircea
Fixed formatting paths
Removed casts, replaced with reactive version target support
Removed WindowsNoEditor
break-all Style => Class, removed optional ? for mod on ModInfo
chore: remove script from 7c4ced3 since it's in its own pr now
chore: fixes from code review
Added VersionTarget/VersionDependency to graphql keys config
fixed alignment of icons and text
feat: add sml engine version
chore: format
Co-authored-by: Robb [email protected]
Co-authored-by: Vilsol [email protected]