feat: allow missing GameVersion if SML dependency is present

satisfactorymodding · Aug 11, 2024 · 3f247ae · 3f247ae
1 parent a66ac66
commit 3f247ae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/lib/components/versions/VersionForm.svelte b/src/lib/components/versions/VersionForm.svelte
@@ -88,7 +88,13 @@
               </span>
             {/if}
 
-            <span><strong>Game version:</strong> {$modMeta.uplugin.GameVersion}<br /></span>
+            {#if $modMeta.uplugin.GameVersion !== undefined}
+              <span><strong>Game version:</strong> {$modMeta.uplugin.GameVersion}<br /></span>
+            {:else}
+              <span class="text-yellow-600">
+                {$t('version-form.missing-game-version')}
+              </span>
+            {/if}
           </p>
 
           <span><strong>Targets:</strong> {$modMeta.targets.join(', ')}<br /></span>

diff --git a/src/lib/models/versions.ts b/src/lib/models/versions.ts
@@ -48,9 +48,12 @@ const readUPluginJson = async (
 
   const parsed = JSON.parse(uPluginJson) as VersionMetadata['uplugin'];
 
-  if (!parsed.GameVersion) {
+  const hasSMLDependency = parsed.Plugins?.some((plugin) => plugin.Name === 'SML');
+  const hasGameVersion = !!parsed.GameVersion;
+
+  if (!hasSMLDependency && !hasGameVersion) {
     return {
-      message: `missing GameVersion in ${modReference}.uplugin`
+      message: `either GameVersion or SML dependency must be present in ${modReference}.uplugin`
     };
   }