fix: do not add zero-length filenames in per-target zips #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's complaining about https://academy.unrealengine.com/ being unreachable (HTTP 504) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 16.95% 16.94% -0.01%
==========================================
Files 103 103
Lines 5437 5440 +3
==========================================
Hits 922 922
- Misses 4414 4417 +3
Partials 101 101 ☔ View full report in Codecov by Sentry. |
Vilsol
approved these changes
Feb 6, 2024
Rewrite the compound conditional to avoid future confusions. This bug has gone unnoticed for so long because Alpakit-generated zip files do not contain folder entries when iterating with a `zipReader`. However, manually generated zip files, e.g. ContentLib mods, could contain folder entries depending on the zipping program used. The resulting zero-length folder in the per-target zips breaks SMM2 on Windows, but not SMM3.
Vilsol
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the compound conditional to avoid future confusions. This bug has gone unnoticed for so long because Alpakit-generated zip files do not contain folder entries when iterating with a
zipReader. However, manually generated zip files, e.g. ContentLib mods, could contain folder entries depending on the zipping program used. The resulting zero-length folder in the per-target zips breaks SMM2 on Windows, but not SMM3.